feat: staking #639
feat: staking #639
Conversation
…e into feat/staking
| //0.1 | ||
| Conviction::None => FixedU128::from_inner(100_000_000_000_000_000_u128), |
There was a problem hiding this comment.
Why? from_rational() is doing wasteful computations in this case and in my opinion readability improvement won't be that high.
This is basically set and forget, this value may won't be changed ever
| fn is_referendum_finished(index: ReferendumIndex) -> bool; | ||
| } | ||
|
|
||
| pub(crate) trait ActionData { |
There was a problem hiding this comment.
What's the purpose of this trait? I believe we can live happily without it and implement the methods directly for Vote struct.
There was a problem hiding this comment.
| /// Unit we are distributing action points for. | ||
| /// e.g if RewardedVoteUnit is 1HDX user will receive `x` action points per each voted 1 HDX. | ||
| #[pallet::constant] | ||
| type RewardedVoteUnit: Get<Balance>; |
There was a problem hiding this comment.
I have a hard time to understand what the param does from the comment. Is it the amount corresponding to 1 action point?
There was a problem hiding this comment.
Not necessarily, amount of action points distributed per "unit" is also configurable.
e.g it can be cofigrted to distribute 4 action points per each voted 25HDX
| AlreadyInitialized, | ||
|
|
||
| /// Arithmetic error. | ||
| Arithmetic, |
There was a problem hiding this comment.
can be replaced by ArithmeticError::Overflow
There was a problem hiding this comment.
This was refactored by @enthusiastmartin so he can reason why
Description
Staking pallet allows users to stake HDX tokens with loyalty(time) and governance actions incentivization.