Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generic create registry asset which accepts asset type #649

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

enthusiastmartin
Copy link
Contributor

@enthusiastmartin enthusiastmartin commented Aug 1, 2023

This PR refactors registry trait for asset creation. Previously it was not possible to specify asset type as parameter, so there was not a way to create other assets than share PoolAsset type.

With new types, Stableswap and Bond, it is required to register such type trhough some kind of generic interface.

Hence, the new CreateRegistry trait.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Crate versions that have been updated:

  • pallet-asset-registry: v2.2.3 -> v2.2.4
  • hydradx-traits: v2.4.0 -> v2.5.0

Runtime version has not been increased.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (c7fa065) 65.01% compared to head (b935014) 64.95%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   65.01%   64.95%   -0.06%     
==========================================
  Files         137      138       +1     
  Lines        9899     9908       +9     
==========================================
  Hits         6436     6436              
- Misses       3463     3472       +9     
Files Changed Coverage Δ
pallets/asset-registry/src/lib.rs 83.92% <0.00%> (-1.53%) ⬇️
pallets/asset-registry/src/types.rs 0.00% <0.00%> (ø)
traits/src/registry.rs 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enthusiastmartin enthusiastmartin marked this pull request as ready for review August 1, 2023 09:29
@enthusiastmartin enthusiastmartin merged commit 07f3d0f into master Aug 2, 2023
8 checks passed
@enthusiastmartin enthusiastmartin deleted the feat/registry-create-trait branch August 2, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants