Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lower minTotalFarmRewards for xyk liquidity mining #914

Merged
merged 1 commit into from
Sep 29, 2024
Merged

chore: lower minTotalFarmRewards for xyk liquidity mining #914

merged 1 commit into from
Sep 29, 2024

Conversation

martinfridrich
Copy link
Contributor

This PR lowers MinTotalFarmRewards for xyk liquidity mining.
This is safe to lower as farms' creation needs to go through governance.

dmoka
dmoka approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@dmoka dmoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected to have a failing test to fix, apart from that LGTM.

Or is it not covered by integration test?

@martinfridrich
Copy link
Contributor Author

yes, this is not covered by integration test.

@github-actions GitHub Actions
Copy link

Crate versions that have been updated:

  • hydradx-runtime: v259.0.0 -> v260.0.0

Runtime version has been increased.

@martinfridrich martinfridrich merged commit eddc67f into master Sep 29, 2024
7 checks passed
@martinfridrich martinfridrich deleted the chore/lower-xyk-lm-min-total-rewards branch September 29, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmoka dmoka dmoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinfridrich @dmoka