Implemented PATCH request support #968
Conversation
|
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
|
Approved for building |
Signed-off-by: Hariprasada <[email protected]>
techcobweb
force-pushed
the
story/hariprasad/galasa-story-1951
branch
from
d570409 to
74141a9
Compare
|
Approved for building |
|
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
|
Approved for building |
There was a problem hiding this comment.
@haripra86 You need to bump the version of the plugin up to 0.36.0 in the build.gradle file version = "0.36.0". Beyond that it all looks good.
Otherwise your change won't get used or distributed.
You mean build.gradle of httpmanager module only or manager parent ? |
|
Approved for building |
I mean the httpmanager. I think it's probably wise to bump the parent also, though the parent project doesn't really matter I believe, as it's just a grouping mechanism. |
|
We are about to start releasing v0.36.0, so you may have to uplift those changes to v0.37.0 instead if this PR doesn't go in in the next day or so. |
|
Do you want me to do the version bump-up if you don't feel comfortable doing it ? |
Signed-off-by: haripra86 <[email protected]>
|
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
@techcobweb I have uplifted httpmanager version to 0.36.0 |
|
Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building' |
|
Approved for building |
|
@techcobweb There is one commit marked as unverified and hence merging is blocked for me. |
|
Build successful |
|
@haripra86 Hi, you should now be able to merge this PR in, I have unblocked the signing issue for now and the builds have passed. |
|
I took the liberty of merging this PR into main, so it will be shipped as part of the 0.36.0 release this week (hopefully). I realise that contributing to Galasa isn't the easiest. We are planning to change things to make it far easier, github actions, a single mono-repo. So hopefully this will get better. On behalf of the Galasa project, thanks very much for your contribution. -Mike. |
galasa-dev/projectmanagement#1951