Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Implemented get user's access token by loginId #269

Merged
merged 17 commits into from
Sep 13, 2024
Merged

Implemented get user's access token by loginId #269

merged 17 commits into from
Sep 13, 2024

Conversation

aashir21
Copy link
Contributor

@aashir21 aashir21 commented Sep 3, 2024 •
edited
Loading

Why

This change will access couchdb and will get filtered access tokens based on the loginId provided.

Signed-off-by: Aashir Siddiqui [email protected]

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-extensions-pr-269-5t92l for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-extensions-pr-269-d5jx7 for details. If you are unable to do so, please contact a member of the Galasa team.

@aashir21
Removed @OverRide annotation
5768aa4 
Signed-off-by: Aashir Siddiqui <[email protected]>
@galasa-team
Copy link

Build successful

@techcobweb techcobweb self-requested a review September 3, 2024 12:27
techcobweb
techcobweb suggested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@techcobweb techcobweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first pass. Impressive. Some improvements I'd like to see though. Happy to discuss further as required.

@aashir21
Made java beans for couchdb
768dc62 
Signed-off-by: Aashir Siddiqui <[email protected]>
@aashir21
Handling couch db version class added
bc04474 
Signed-off-by: Aashir Siddiqui <[email protected]>
@aashir21
Added comparable
12411ef 
Signed-off-by: Aashir Siddiqui <[email protected]>
@aashir21
Used couchdb version inside couchdb validator
ac3028b 
Signed-off-by: Aashir Siddiqui <[email protected]>
@aashir21
Added error and logging messages
f457ae6 
Signed-off-by: Aashir Siddiqui <[email protected]>
@galasa-team
Copy link

Build successful

@aashir21
Added galasa copyright text
f4e6717 
Signed-off-by: Aashir Siddiqui <[email protected]>
@galasa-team
Copy link

Build successful

eamansour
eamansour reviewed Sep 5, 2024
View reviewed changes
...a.auth.couchdb/src/main/java/dev/galasa/auth/couchdb/internal/CouchdbAuthStoreValidator.java Show resolved Hide resolved
...a.auth.couchdb/src/main/java/dev/galasa/auth/couchdb/internal/CouchdbAuthStoreValidator.java Outdated Show resolved Hide resolved
...a.auth.couchdb/src/main/java/dev/galasa/auth/couchdb/internal/CouchdbAuthStoreValidator.java Outdated Show resolved Hide resolved
...a.auth.couchdb/src/main/java/dev/galasa/auth/couchdb/internal/CouchdbAuthStoreValidator.java Outdated Show resolved Hide resolved
...rent/dev.galasa.auth.couchdb/src/test/java/dev/galasa/auth/couchdb/TestCouchdbAuthStore.java Show resolved Hide resolved
...galasa.auth.couchdb/src/test/java/dev/galasa/auth/couchdb/TestCouchdbAuthStoreValidator.java Outdated Show resolved Hide resolved
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-extensions-pr-269-c4szg for details. If you are unable to do so, please contact a member of the Galasa team.

@aashir21
Implemented the changes requested
86a1603 
Signed-off-by: Aashir Siddiqui <[email protected]>
@galasa-team
Copy link

Build successful

techcobweb
techcobweb approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@techcobweb techcobweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to those few changes I suggested.

@aashir21 aashir21 merged commit 8914b41 into main Sep 13, 2024
5 checks passed
@aashir21 aashir21 deleted the Iss1976 branch September 13, 2024 09:28
@eamansour eamansour mentioned this pull request Sep 16, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eamansour eamansour eamansour approved these changes

@techcobweb techcobweb techcobweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aashir21 @galasa-team @techcobweb @eamansour