Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Provide network name in CPS to get network ID #970

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Provide network name in CPS to get network ID #970

merged 2 commits into from
Aug 6, 2024

Conversation

jadecarino
Copy link
Contributor

@jadecarino jadecarino commented Aug 6, 2024

Why?

Attempting to fix galasa-dev/projectmanagement#1956

  • Remove changes from yesterday in OpenstackHttpClient.
  • Add CPS property for providing the Network Name you wish to allocate a Floating IP on, that is then used to get the Network ID. There is now two external Networks available instead of one so the previous logic did not use a configurable Network Name and simply picked the first (and only) external network. There are now two and assuming the results come back in alphabetical order, the wrong network is always selected.
  • Versions already at 0.36.0.
  • Fixed Javadoc as per Mike's comments.

@galasa-team
Copy link
Contributor

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-managers-pr-970-h4w5n for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Jade Carino <[email protected]>
@galasa-team
Copy link
Contributor

Build successful

@jadecarino jadecarino merged commit 7418551 into main Aug 6, 2024
6 checks passed
@jadecarino jadecarino deleted the iss1956 branch August 6, 2024 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenStack create floating IP Bad Request
3 participants