Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

OBR script changes #177

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OBR script changes #177

wants to merge 3 commits into from

Conversation

Tom-Slattery
Copy link

The OBR script seems to set the value of GALASA_BUILD_TOOL_PATH using the get_galasabld_binary_location method, then overwrite that value for each method that uses galasabld. This causes the script to fail for me when galasabld is on my path. I've removed the extra setting of GALASA_BUILD_TOOL_PATH and used the value obtained by get_galasabld_binary_location.

For each mvn call I've added:
--settings ${WORKSPACE_DIR}/obr/settings.xml
-Dgpg.skip=true \

So that maven uses the settings.xml file in the workspace, allowing the value of galasa.source.repo and galasa.central.repo to be use (otherwise this fails for me).

I've also skipped gpg signing here as the maven calls seem to only pull from remote Maven and build to local Maven - signing didn't seem necessary here.

Signed-off-by: Tom Slattery <[email protected]>
build-locally.sh Outdated Show resolved Hide resolved
Copy link
Member

@eamansour eamansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to resolving the above comment

@Tom-Slattery
Copy link
Author

Tom-Slattery commented Sep 16, 2024

Addressed the GPG Passphrase with the new commit. Also wanted to mention that I've added extensions to the dependency download step as that wasn't in my original comment:

    runtimeOnly group: 'dev.galasa', name: 'dev.galasa.extensions.manifest', version: version, ext: "yaml"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants