Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass token description to the API server when creating a new access token #35

Merged
merged 2 commits into from
May 23, 2024

Conversation

eamansour
Copy link
Member

Why?

See galasa-dev/projectmanagement#1805

Note: Builds for this PR will fail until galasa-dev/framework#546 is reviewed and merged

Changes

  • Added logic to pass the submitted token description to the API server when sending a POST request to create a new personal access token
    • This is currently achieved using a token_description cookie to maintain the token description after several redirects (e.g. to the configured auth connector, and back to the webui).

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-webui-pr-35-gdv96 for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <[email protected]>
@galasa-team
Copy link

Build successful

@eamansour eamansour merged commit 815d465 into main May 23, 2024
4 checks passed
@eamansour eamansour deleted the iss1805-list-tokens branch May 23, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants