Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web-UI now displays login times on profile page #67

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Web-UI now displays login times on profile page #67

merged 5 commits into from
Nov 4, 2024

Conversation

aashir21
Copy link
Contributor

@aashir21 aashir21 commented Nov 1, 2024 •
edited
Loading

@aashir21 aashir21 changed the title ash users webui Web-UI now displays login times on profile page Nov 1, 2024
eamansour
eamansour approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@eamansour eamansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but approved

galasa-ui/src/app/myprofile/page.tsx Outdated Show resolved Hide resolved
galasa-ui/src/tests/routes/users.test.ts Show resolved Hide resolved
galasa-ui/src/utils/interfaces/FrontEndClient.ts Outdated Show resolved Hide resolved
galasa-ui/src/app/myprofile/page.tsx Outdated Show resolved Hide resolved
galasa-ui/src/app/myprofile/page.tsx Outdated Show resolved Hide resolved
@aashir21 aashir21 merged commit 83997b0 into main Nov 4, 2024
5 checks passed
@aashir21 aashir21 deleted the ash-users-webui branch November 4, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamansour eamansour eamansour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aashir21 @eamansour