disable galaxy config sorting #218
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, sort_keys is set to true in the to_nice_yaml function. Sorting the brand_by_host affects the branding of the subdomains, especially when the root domain is added before the subdomain brand due to the sorting.
|
ping @natefoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EU @bgruening observed that the brand_by_host gets sorted in the final configuration when written to disk (
galaxy.ymlfile). As a result of this sorting, the usegalaxy.eu: Europe comes before the subdomain virology.usegalaxy.eu: Virology, which leads to the misbranding of the subdomain https://virology.usegalaxy.eu. This subdomain contains the brandEuropeinstead ofVirology.Example (final config from
galaxy.yml):By default,
sort_keysis set totruein theto_nice_yamlfunction in thegalaxy.yml.j2template. Sorting thebrand_by_hostin Galaxy config affects the branding of the subdomains. Therefore, this PR disables the defaultsort_keys.@natefoo, I am unsure whether the default sorting is needed for anything in Galaxy configuration. Please correct me if this is not the case.