Add possibility to install a custom compiled slurm package #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update main.yml * Update defaults/main.yml Co-authored-by: Bruno Travouillon <[email protected]> * install custom packages * install custom packages * install custom packages * add custom debain repositories * install custom packages * install custom packages * fix typo dynamique vars * fix the FQCN * add configure custom repos * add example of custom repo * add new README.md Co-authored-by: Bruno Travouillon <[email protected]> * remove custom package installtion * remove condition slurm_apt_repository * fix typo * remove slurm_apt_repository condition * remove slurm_apt_repository condition * fix custom log directory creation * move var to first part * rename the var to static * fix var --------- Co-authored-by: Bruno Travouillon <[email protected]> Co-authored-by: ahmed <[email protected]>
(cherry picked from commit 712cf32)
(cherry picked from commit 936e64a)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tasks/slurmdbd_cluster.yml
Outdated
| @@ -0,0 +1,20 @@ | |||
| --- | |||
|
|
|||
| - name: Check for existence of cluster in db. | |||
There was a problem hiding this comment.
[ansible-lint] reported by reviewdog 🐶
no-changed-when Commands should not change things if nothing needs doing
tasks/slurmdbd_cluster.yml
Outdated
| @@ -0,0 +1,20 @@ | |||
| --- | |||
|
|
|||
| - name: Check for existence of cluster in db. | |||
There was a problem hiding this comment.
[ansible-lint] reported by reviewdog 🐶
risky-shell-pipe Shells that use pipes should set the pipefail option
SlurmctldHost can be defined more than once in slurm.conf to define a primary and backups Slurm controllers. If SlurmctldHost is defined as a list in `slurm_config`, then the template will add one line per list item in slurm.conf..
When ansible-playbook is called with `-e slurm_start_services=false`, the variable is evaluated as a string (which is true). Apply the `| bool` filter to evaluate the variable as a boolean.
While the new feature to create a new SlurmDBD cluster could be nice in some cases, it causes some issues when one wants to reinstall a node with an existing database. IMHO, it is safer to disable this by default. One should opt-in for Ansible to create a new cluster.
Make sure to execute the correct Slurm after the upgrade. Otherwise, this may cause issues when reloading the service during logrotate since some files changed on the system.
Make sure to execute the correct Slurm after the upgrade. Otherwise, this may cause issues when reloading the service during logrotate since some files changed on the system.
Comment on lines
+6
to
+9
|
|
||
| - name: Include Configure custom repositories | ||
| ansible.builtin.include_tasks: repositories-Debian.yml | ||
| when: slurm_configure_repos |
There was a problem hiding this comment.
Should this support RHEL-like distros as well?
At least, this task should not execute when a host's family OS is not Debian.
Upon changes, some tasks will trigger the reload handler while others will trigger the restart handler. During initial installation of Slurm with the role, this can lead to some race condition where reload and restart will execute too closely one from the other, which can trigger a failure of the second service. When a restart handler is notified, there should be no need to trigger the reload as well. Move the restart handlers before the reload handlers to make sure those are executed first. Register their result in a variable. Test if the variable is defined in the reload handler (which means that the restart handler was executed). Also remove one of the 'Reload slurmdbd' handler which was defined twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to install custom slurm packages, the objective to install the most recent vesrion slurm on debian or ubuntu.