Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize the image used for init containers. #500

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ksuderman
Copy link
Contributor

Most images used can be specified, and overridden, in the values.yaml file. Except the images used in the init containers in the jobs_init.yaml template.

This PR parameterizes those images (four in total) as well. The only issue to be settled is where in the values.yaml file these should be specified. For now I have added them under the jobs block:

#- Additional dynamic rules to map into the container.
jobs:
  init:
    #- The Docker image to use for the init containers
    image:
      repository: alpine
      tag: 3.16
      pullPolicy: IfNotPresent

Closes #499

@ksuderman ksuderman added the minor label Sep 6, 2024
Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nuwang nuwang merged commit b87ce3d into master Sep 9, 2024
2 checks passed
@nuwang nuwang deleted the 499-init-container-image branch September 9, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to set custom container image repositories for init containers
2 participants