Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined/null urls in fix-links.mjs. #1464

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

NickSto
Copy link
Member

@NickSto NickSto commented Jun 21, 2022

This addresses an error which can arise in fix-links.mjs in the unusual situation where the url on a node is undefined. Now, instead of crashing the build, this will print a useful warning, leave the link unaltered, and continue.

This error was discovered in #1437, being caused by something in the large svg blob in content/projects/ppandemic/s1e1/index.md.

@NickSto NickSto added the bugfix label Jun 21, 2022
@NickSto NickSto merged commit 9582132 into galaxyproject:master Jun 22, 2022
@NickSto NickSto deleted the handle-empty-links branch June 22, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant