Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP blog about Galaxy at PASC #2066

Merged
merged 11 commits into from
Jul 6, 2023
Merged

WIP blog about Galaxy at PASC #2066

merged 11 commits into from
Jul 6, 2023

Conversation

hrhotz
Copy link
Contributor

@hrhotz hrhotz commented Jul 5, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 40.3%, saving 675.35 KB.

Filename Before After Improvement Visual comparison
content/news/2023-07-07-PASC-conference/IMG_0685.jpg 360.75 KB 218.64 KB -39.4% View diff
content/news/2023-07-07-PASC-conference/IMG_0701.jpg 711.41 KB 403.43 KB -43.3% View diff
content/news/2023-07-07-PASC-conference/IMG_0704.jpg 602.46 KB 377.20 KB -37.4% View diff

3642 images did not require optimisation.

bgruening
bgruening approved these changes Jul 5, 2023
View reviewed changes
content/news/2023-07-07-PASC-conference/index.md Outdated Show resolved Hide resolved
content/news/2023-07-07-PASC-conference/index.md Outdated Show resolved Hide resolved
content/news/2023-07-07-PASC-conference/index.md Outdated Show resolved Hide resolved
@bgruening
Copy link
Member

@dannon do you know why it does not find the images?

http://localhost:8080/news/2023-07-07-pasc-conference/

  • ./IMG_0701.jpg
  • ./IMG_0685.jpg
  • ./IMG_0704.jpg

@bgruening
Copy link
Member

@hrhotz could you please turn this one image?

@volodymyrss
Copy link
Contributor

Look great, thanks @hrhotz!

@hrhotz
Copy link
Contributor Author

hrhotz commented Jul 6, 2023

@bgruening
eh?? I am pretty sure that image was correct originally - did this happen as part of the 'automagically compressed' step?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 43.3%, saving 307.98 KB.

Filename Before After Improvement Visual comparison
content/news/2023-07-07-PASC-conference/IMG_0701.2.jpg 711.41 KB 403.43 KB -43.3% View diff

3646 images did not require optimisation.

@hrhotz
Copy link
Contributor Author

hrhotz commented Jul 6, 2023

@bgruening I have exchanged the picture (new: "IMG_0701.2.jpg"). It has been correct, and now after "Calibre's image-actions" has worked on it as well, it is turned again.

excuse my ignorance: do you have any ideas on how to revert this?

@dannon
Copy link
Member

dannon commented Jul 6, 2023

Sorry I missed the ping here, will try to see what's going on locally

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 1.1%, saving 4.61 KB.

Filename Before After Improvement Visual comparison
content/news/2023-07-07-PASC-conference/IMG_0701.jpg 408.17 KB 403.56 KB -1.1% View diff

3645 images did not require optimisation.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 1.1%, saving 4.61 KB.

Filename Before After Improvement Visual comparison
content/news/2023-07-07-PASC-conference/IMG_0701.jpg 408.17 KB 403.56 KB -1.1% View diff

3646 images did not require optimisation.

@dannon
Copy link
Member

dannon commented Jul 6, 2023

Should be good to go now. Yes, the compression action was actually rotating the image. I manually compressed that, fixed the rotation, then rebased.

@bgruening bgruening merged commit c4a22a7 into master Jul 6, 2023
@bgruening bgruening deleted the hrhotz-patch-5 branch July 6, 2023 20:35
@bgruening
Copy link
Member

Thanks!

@hrhotz
Copy link
Contributor Author

hrhotz commented Jul 7, 2023

@dannon thank you very much for your help !

paulzierep pushed a commit to paulzierep/galaxy-hub that referenced this pull request Jul 26, 2023
@hrhotz @github-actions
@bgruening @dannon @paulzierep
WIP blog about Galaxy at PASC (galaxyproject#2066)
b0521d2 
* Create index.md

* Add files via upload

* Update index.md

* Update index.md

* Optimised images with calibre/image-actions

* Apply suggestions from code review

* mardown images are working

* Add files via upload

* Update index.md

* Optimised images with calibre/image-actions

* Fix images

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Dannon Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrhotz @bgruening @volodymyrss @dannon