Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty lines, comments when reading in packages_by_dep_dag.txt file #7

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Feb 1, 2024

Also, add test; use session-scoped fixtures not to regenerate the same files for each test.

tests/test_release.py Outdated Show resolved Hide resolved
tests/test_release.py Outdated Show resolved Hide resolved
tests/test_release.py Outdated Show resolved Hide resolved
@mvdbeek
Copy link
Member

mvdbeek commented Feb 2, 2024

Can you undo the session changes ? tmp_path is a python fixture, it is virtually free to create a temp dir for isolated tests. Also the pytest config looks weird to me, can you delete that too please ?

@mvdbeek mvdbeek merged commit a09da58 into galaxyproject:main Feb 2, 2024
5 checks passed
@jdavcs
Copy link
Member Author

jdavcs commented Feb 2, 2024

Thanks, the test is much simpler now. About pytest.ini - I mistakenly assumed I needed that for pytest to find the modules to import, which was not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants