Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Upgrade minimum conda to be compatible with latest conda-build #17013

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[23.0] Upgrade minimum conda to be compatible with latest conda-build #17013

merged 1 commit into from
Nov 13, 2023

Conversation

bernt-matthias
Copy link
Contributor

solution for the build problems in galaxyproject/planemo#1388

I manually tested that this solves the problem...

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias bernt-matthias changed the title 23.1 bump conda [23.1] bump conda Nov 12, 2023
@github-actions github-actions bot added this to the 23.2 milestone Nov 12, 2023
@bernt-matthias bernt-matthias mentioned this pull request Nov 12, 2023
Merged
@nsoranzo nsoranzo self-requested a review November 12, 2023 19:13
@bernt-matthias
Copy link
Contributor Author

Still testing. @nsoranzo still has some doubts ..

@mvdbeek mvdbeek changed the title [23.1] bump conda [23.1] Upgrade minimum conda to be compatible with conda_use_local option Nov 13, 2023
@nsoranzo nsoranzo changed the title [23.1] Upgrade minimum conda to be compatible with conda_use_local option [23.1] Upgrade minimum conda to be compatible with latest conda-build Nov 13, 2023
nsoranzo
nsoranzo approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed due to new changes in conda-build, see conda/conda-build#4984 (comment)

@nsoranzo
Copy link
Member

Maybe target release_23.0, which has the same issue and is still supported?

@bernt-matthias
bump required conda version
0aafa22 
potential solution for the build prblems in galaxyproject/planemo#1388
@bernt-matthias bernt-matthias changed the base branch from release_23.1 to release_23.0 November 13, 2023 12:19
@bernt-matthias bernt-matthias changed the title [23.1] Upgrade minimum conda to be compatible with latest conda-build [23.0] Upgrade minimum conda to be compatible with latest conda-build Nov 13, 2023
nsoranzo
nsoranzo approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvdbeek mvdbeek merged commit 1b0c0bb into galaxyproject:release_23.0 Nov 13, 2023
39 checks passed
@github-actions GitHub Actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
area/tool-dependencies area/tool-framework kind/bug
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bernt-matthias @nsoranzo @mvdbeek