Don't use gunicorn logging options with unicornherder #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python logging config instead, so that rotation can be performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use Galaxy's python logging config instead, so that rotation can be performed.
Rotation depends on galaxyproject/galaxy#14457 unless you do a full custom logging config, and the access log entries will be missing from the gunicorn log file (when running under unicornherder) without galaxyproject/galaxy#14467, so this should not be tagged and released until after those are merged.
If you need to set the
log_destinationGalaxy config option from the environment, you can use$GALAXY_CONFIG_OVERRIDE_LOG_DESTINATION.