-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples and cleanup unused #284
Conversation
@@ -48,7 +48,7 @@ The `kubectl` program is only required when bootstrapping a new Galaxy instance, | |||
|
|||
### Credentials | |||
|
|||
You will need an [API key](https://training.galaxyproject.org/training-material/faqs/galaxy/preferences_admin_api_key.html) for every Galaxy instance you would like to intereact with. You will also need the *kubeconfig* file for each Kubernetes cluster. The `abm` script loads the Galaxy server URLs, API keys, and the location of the *kubeconfig* files from a Yaml configuration file that it expects to find in `$HOME/.abm/profile.yml` or `.abm-profile.yml` in the current directory. You can use the `profile-sample.yml` file as a starting point and it includes the URLs for all Galaxy instances we have used to date (December 22, 2021 as of this writing). | |||
You will need an [API key](https://training.galaxyproject.org/training-material/faqs/galaxy/preferences_admin_api_key.html) for every Galaxy instance you would like to intereact with. You will also need the *kubeconfig* file for each Kubernetes cluster. The `abm` script loads the Galaxy server URLs, API keys, and the location of the *kubeconfig* files from a Yaml configuration file that it expects to find in `$HOME/.abm/profile.yml` or `.abm-profile.yml` in the current directory. You can use the `samples/profile.yml` file as a starting point and it includes the URLs for all Galaxy instances we have used to date (December 22, 2021 as of this writing). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current profile.yml does not seem to contain a list of all Galaxy instances as mentioned in the readme.
- history_name: 1 | ||
inputs: | ||
- name: FASTQ RNA Dataset | ||
dataset_id: 28fa757e56346a34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should dataset_ids correspond with datasets.yml in the samples folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The dataset_id
in the benchmark file is the ID (or name) of the dataset in the Galaxy history. So something like ucsc.hg38.knownGene.gtf
. That sample should likely be updated or removed. The datasets.yml
(and histories.yml
andworkflows.yaml
) files are used to provide aliases to URLs that are used when importing datasets/histories/workflows into Galaxy.
abm main dataset import rna-1g
abm main workflow import rnaseq-pe
workflow_conf: | ||
- benchmarks/example.yml | ||
- benchmarks/dna-named.yml | ||
- benchmarks/rna-named.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
benchmark samples need to be updated
- iu2 | ||
job_configs: | ||
- rules/4x8.yml | ||
- rules/8x16.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rule files need sample content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And probably more explanation as the format of the files will depend on what chart was used to install Galaxy. Since GalaxyKubeman installs Galaxy as a dependent chart there is a top level galaxy:
key that is not needed if Galaxy is installed from the galaxy-helm
chart.
I will also give some thought to rewriting this section. For the cloud costs we only update TPV rules, but any values from the Chart can be specified and updated here.
Thanks for the issue and PR! |
Partially addresses: #283