Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for change of base_url in BioBlend 1.2.0 #1379

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix for change of base_url in BioBlend 1.2.0 #1379

merged 1 commit into from
Jul 19, 2023

Conversation

nsoranzo
Copy link
Member

No description provided.

@nsoranzo nsoranzo mentioned this pull request Jul 19, 2023
Merged
bernt-matthias
bernt-matthias reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since having an extra / should not hurt this should also work with older versions of bioblend, or?

@nsoranzo
Copy link
Member Author

Since having an extra / should not hurt this should also work with older versions of bioblend, or?

Yes, I wrote this patch so that it should work whether the base URL ends with a "/" or not.

@nsoranzo nsoranzo merged commit 2f828a1 into galaxyproject:master Jul 19, 2023
@nsoranzo nsoranzo deleted the bioblend_1.2.0 branch July 19, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernt-matthias bernt-matthias bernt-matthias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @bernt-matthias