Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix planemo test workflow when output is collection with identical name #1391

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Try to fix planemo test workflow when output is collection with identical name #1391

merged 2 commits into from
Oct 6, 2023

Conversation

lldelisle
Copy link
Contributor

lldelisle and others added 2 commits October 5, 2023 15:37
@lldelisle
add failing test
830f6d0
@mvdbeek
Suffix filename with uuid
a4dead4 
Don't love it but it'll do for now.
@lldelisle
Copy link
Contributor Author

lldelisle commented Oct 6, 2023 •
edited
Loading

Any idea why the test is not failing on CI?
What did I do wrong? Because it was failing locally...

@mvdbeek
Copy link
Member

mvdbeek commented Oct 6, 2023

It would have run in https://github.com/galaxyproject/planemo/actions/runs/6421040087/job/17434490532, but that was cancelled.

@mvdbeek
Copy link
Member

mvdbeek commented Oct 6, 2023

And yeah, it's failing locally for me too and my commit fixes this.

@lldelisle
Copy link
Contributor Author

Great!
Should I try to fix the CI into another PR?

@mvdbeek
Copy link
Member

mvdbeek commented Oct 6, 2023

I think this is conda timing out, that probably needs to be fixed on the Galaxy or Conda side ...

@mvdbeek mvdbeek merged commit 9daa9ba into galaxyproject:master Oct 6, 2023
10 of 14 checks passed
@lldelisle lldelisle deleted the wf_same_output_name branch October 6, 2023 18:57
@lldelisle
Copy link
Contributor Author

Thanks for the fix.

@mvdbeek
Copy link
Member

mvdbeek commented Oct 6, 2023

Thanks for the test, that made it easy!

mvdbeek added a commit to mvdbeek/planemo that referenced this pull request Oct 26, 2023
@mvdbeek
Fix checksum check for wf7-collection-output.gxwf-test.yml
6a6645c 
The previous checksum is for an empty string. I think this has been
wrong from the start because the code for downloading outputs was broken
and only fixed in galaxyproject#1391
mvdbeek added a commit to mvdbeek/planemo that referenced this pull request Oct 26, 2023
@mvdbeek
Fix checksum check for wf7-collection-output.gxwf-test.yml
9aaa78d 
The previous checksum is for an empty string. I think this has been
wrong from the start because the code for downloading outputs was broken
and only fixed in galaxyproject#1391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lldelisle @mvdbeek