Merge pull request #30 from galenwarren/remove-firebase

fix: fix addAttribute to ignore empty value
galenwarren · Sep 8, 2018 · b9c3a2f · b9c3a2f
2 parents e8a14b7 + 219ddf0
commit b9c3a2f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 124 deletions.
diff --git a/src/firebase/realtime/__tests__/realtime.js b/src/firebase/realtime/__tests__/realtime.js
diff --git a/src/firebase/realtime/index.js b/src/firebase/realtime/index.js
diff --git a/src/firebase/realtime/realtime.js b/src/firebase/realtime/realtime.js
diff --git a/src/operators.js b/src/operators.js
@@ -1,4 +1,5 @@
 import { Observable } from 'rxjs';
+import { map } from 'rxjs/operators';
 
 export function afterUnsubscribe(action, delay) {
   return source =>
@@ -16,11 +17,15 @@ export function afterUnsubscribe(action, delay) {
 export function addAttribute(key, attributeValue) {
   return source =>
     Observable.create(subscriber => {
-      return source.subscribe(
-        value =>
-          subscriber.next(Object.assign({}, value, { [key]: attributeValue })),
-        error => subscriber.error(error),
-        () => subscriber.complete()
-      );
+      return source
+        .pipe(
+          map(
+            value =>
+              value
+                ? Object.assign({}, value, { [key]: attributeValue })
+                : value
+          )
+        )
+        .subscribe(subscriber);
     });
 }