Merge branch 'BimmerGestalt-main'

.github/workflows/build.yml

@@ -15,6 +15,11 @@ jobs:
         with:
           fetch-depth: 0
           submodules: true
+      - name: Set up JDK 17
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'zulu'
+          java-version: 17
 
       - name: Prepare cached external dependencies
         uses: actions/cache@v3
@@ -27,8 +32,23 @@ jobs:
 
       - name: Validate Gradle Wrapper
         uses: gradle/wrapper-validation-action@v1
-      - name: Build the project
+
+      - name: Extract signing key
+        if: github.repository == 'BimmerGestalt/IDriveConnectAddons' && github.ref == 'refs/heads/main'
+        run: "echo '${{ secrets.KEYSTORE_BASE64 }}' | base64 -d > keystore.jks"
+
+      - name: Build the project (debug mode)
+        if: github.repository != 'BimmerGestalt/IDriveConnectAddons' || github.ref != 'refs/heads/main'
         run: ./gradlew assembleDebug
+
+      - name: Build the project (release mode)
+        if: github.repository == 'BimmerGestalt/IDriveConnectAddons' && github.ref == 'refs/heads/main'
+        run: ./gradlew assembleRelease
+        env:
+          KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
+          KEYSTORE_ALIAS: upload
+          KEYSTORE_ALIAS_PASSWORD: ${{ secrets.KEYSTORE_ALIAS_PASSWORD }}
+
       - name: Upload APKs
         uses: actions/upload-artifact@v3
         with:
@@ -67,7 +87,7 @@ jobs:
       - name: Stage upload directory
         run: |
           mkdir dist
-          cp */build/outputs/apk/debug/*apk dist/
+          cp */build/outputs/apk/*/*apk dist/
       - name: Upload to Github releases
         uses: svenstaro/upload-release-action@v2
         with:

README.md

@@ -1,7 +1,7 @@
 # IDriveConnectAddons
 
 The Connected Apps protocol is very powerful and provides an unparalleled convergence experience.
-While the AAIdrive app focuses on a specific feature set, creative people could implement their own ideas to unlock other functionality!
+While the AAIdrive app focuses on a specific feature set, addons providing extra functionality have been [built and released](https://github.com/BimmerGestalt/IDriveConnectAddons/releases) and creative people could implement their own ideas to unlock other possibilities!
 
 # Current Integrations
 
@@ -19,6 +19,7 @@ There's also the concept of a Car Connection Addon, which starts up and shuts do
 
 - [screen_mirror](screen_mirror) adds an app to the car to show a copy of the phone screen on the car's screen.
 - [Hass Gestalt](https://github.com/BimmerGestalt/HassGestalt) provides access to Home Assistant dashboards in the car's screen
+- [ReadYou Gestalt](https://github.com/BimmerGestalt/ReadYou) adds an RSS news app to the car's screen, based on [ReadYou](https://f-droid.org/packages/me.ash.reader/)
 
 # Future Ideas
 
@@ -30,15 +31,15 @@ The car provides [so much data](https://bimmergestalt.github.io/BMWConnectedAnal
 - Fuel logger, automatically reporting fill-ups to Fuelly or Spritmonitor
 - Scrobbling of car-sourced music such as SiriusXM or USB (basic implementation in [bimmerscrobbler](bimmerscrobbler))
 - Live gauges display of some basic performance data, without needing extra hardware (simple example in [cds_gauges](cds_gauges))
-- Car race recording, inspired by BMW M Laptimer (one approach enabled with [androbd_gestalt](androbd_gestalt))
+- Car race recording, inspired by BMW M Laptimer (one attempt with [androbd_gestalt](androbd_gestalt))
 - Automatically load VIN from the car to decode the list of options that the car came with
 
 ## Legacy Apps
 
 There were previously some incredibly innovative features using the Connected Apps protocol, perhaps they can be brought back and updated?
 
 - Official Twitter client could be reused for Mastodon
-- Perhaps integrated with the official RSS News reader
+- Official RSS News reader (implemented as a [fork of ReadYou](https://github.com/BimmerGestalt/ReadYou))
 - Dynamic Music would be fun
 - Sports Displays could be reused for accelerometer display, perhaps?
 - Smart Things could be a frontend for Home Assistant (implemented as [Hass Gestalt](https://github.com/BimmerGestalt/HassGestalt))
@@ -65,7 +66,7 @@ By using AM App Icons as launchers into other apps, we can essentially create cu
 
 The protocol has some other APIs which haven't been fully explored, such as the Map api that takes a KMZ file. This might enable some fun features:
 
-- Add a POI layer to show speed traps (blitzer.de Flitsmeister Yasonik, for example). OSM has some of [this data](https://wiki.openstreetmap.org/wiki/Relation:enforcement).
+- Add a POI layer to show speed traps (blitzer.de Flitsmeister Yanosik, for example). OSM has some of [this data](https://wiki.openstreetmap.org/wiki/Relation:enforcement).
 - Add a POI layer to show addresses of contacts from the phone's address book
 
 Turns out this map functionality is less of a POI layer and more like a mini map showing search results, which lends itself to different functionality:

androbd_gestalt/build.gradle

@@ -5,26 +5,37 @@ plugins {
 }
 
 android {
-    compileSdkVersion 30
-    buildToolsVersion "30.0.0"
 
     defaultConfig {
         applicationId "io.bimmergestalt.idriveconnectaddons.androbd_gestalt"
+        compileSdk 33
         minSdkVersion 21
-        targetSdkVersion 30
+        targetSdkVersion 33
         versionCode 1
         versionName "1.0"
 
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
+    signingConfigs {
+        release
+    }
+    if (System.getenv("CI") == "true") {
+        // configure keystore
+        signingConfigs.release.storeFile = file("../keystore.jks")
+        signingConfigs.release.storePassword = System.getenv("KEYSTORE_PASSWORD")
+        signingConfigs.release.keyAlias = System.getenv("KEYSTORE_ALIAS")
+        signingConfigs.release.keyPassword = System.getenv("KEYSTORE_ALIAS_PASSWORD")
+    }
+
     buildFeatures {
         dataBinding true
     }
     buildTypes {
         release {
             minifyEnabled false
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
+            signingConfig signingConfigs.release
         }
     }
     compileOptions {
@@ -34,6 +45,7 @@ android {
     kotlinOptions {
         jvmTarget = '1.8'
     }
+    namespace 'io.bimmergestalt.idriveconnectaddons.androbd_gestalt'
 }
 
 repositories {

androbd_gestalt/src/main/AndroidManifest.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="io.bimmergestalt.idriveconnectaddons.androbd_gestalt">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <uses-permission android:name="io.bimmergestalt.permission.CDS_normal" />
     <uses-permission android:name="io.bimmergestalt.permission.CDS_personal" />
@@ -11,7 +10,7 @@
         android:roundIcon="@mipmap/ic_launcher_round"
         android:supportsRtl="true"
         android:theme="@style/Theme.IDriveConnectAddons">
-        <activity android:name=".MainActivity">
+        <activity android:name=".MainActivity" android:exported="true">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
             </intent-filter>
@@ -40,7 +39,7 @@
         </service>
 
         <!-- Become discoverable in the Addons tab -->
-        <service android:name=".GestaltPlugin">
+        <service android:name=".GestaltPlugin" android:exported="true">
             <intent-filter>
                 <action android:name="io.bimmergestalt.cardata.service" />
             </intent-filter>

bimmerscrobbler/build.gradle

@@ -5,26 +5,37 @@ plugins {
 }
 
 android {
-    compileSdkVersion 30
-    buildToolsVersion "30.0.0"
 
     defaultConfig {
         applicationId "io.bimmergestalt.idriveconnectaddons.bimmerscrobbler"
+        compileSdk 33
         minSdkVersion 21
-        targetSdkVersion 30
+        targetSdkVersion 33
         versionCode 1
         versionName "1.0"
 
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
+    signingConfigs {
+        release
+    }
+    if (System.getenv("CI") == "true") {
+        // configure keystore
+        signingConfigs.release.storeFile = file("../keystore.jks")
+        signingConfigs.release.storePassword = System.getenv("KEYSTORE_PASSWORD")
+        signingConfigs.release.keyAlias = System.getenv("KEYSTORE_ALIAS")
+        signingConfigs.release.keyPassword = System.getenv("KEYSTORE_ALIAS_PASSWORD")
+    }
+
     buildFeatures {
         dataBinding true
     }
     buildTypes {
         release {
             minifyEnabled false
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
+            signingConfig signingConfigs.release
         }
     }
     compileOptions {
@@ -34,6 +45,7 @@ android {
     kotlinOptions {
         jvmTarget = '1.8'
     }
+    namespace 'io.bimmergestalt.idriveconnectaddons.bimmerscrobbler'
 }
 
 repositories {

bimmerscrobbler/src/main/AndroidManifest.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="io.bimmergestalt.idriveconnectaddons.bimmerscrobbler">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <uses-permission android:name="io.bimmergestalt.permission.CDS_normal" />
     <application
@@ -10,7 +9,7 @@
         android:roundIcon="@mipmap/ic_launcher_round"
         android:supportsRtl="true"
         android:theme="@style/Theme.IDriveConnectAddons">
-        <activity android:name=".MainActivity">
+        <activity android:name=".MainActivity" android:exported="true">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
 
@@ -21,7 +20,7 @@
 
         <!-- Become discoverable in the Addons tab -->
         <!-- Also becomes bound when the car connects -->
-        <service android:name=".MainService">
+        <service android:name=".MainService" android:exported="true">
             <intent-filter>
                 <action android:name="io.bimmergestalt.cardata.service" />
             </intent-filter>