Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity Fixes with Test Runner (QOL Changes) #607

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Parity Fixes with Test Runner (QOL Changes) #607

merged 6 commits into from
Dec 13, 2023

Conversation

AndrewKahr
Copy link
Member

Changes

  • Better activation/return license logic
  • Code cleanup

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

Merging #607 (d0145e5) into main (9406bce) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

❗ Current head d0145e5 differs from pull request most recent head 33fd1e5. Consider uploading reports for the commit 33fd1e5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   37.43%   37.40%   -0.04%     
==========================================
  Files          75       75              
  Lines        3045     3048       +3     
  Branches      631      632       +1     
==========================================
  Hits         1140     1140              
- Misses       1756     1759       +3     
  Partials      149      149              
Files Coverage Δ
src/model/image-tag.ts 48.31% <100.00%> (ø)
src/model/docker.ts 10.63% <0.00%> (-0.73%) ⬇️

@AndrewKahr AndrewKahr merged commit ff23166 into main Dec 13, 2023
51 checks passed
@AndrewKahr AndrewKahr deleted the misc-fixes branch December 13, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants