Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes for 4.2.0 #630

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Hotfixes for 4.2.0 #630

merged 3 commits into from
Feb 19, 2024

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Feb 19, 2024

Changes

  • Fix skipActivation not passed to macos ENV
  • Fix linux il2cpp image tag for non-cloudrunner execution

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4ae184c) 36.97% compared to head (d17e484) 36.93%.

❗ Current head d17e484 differs from pull request most recent head b6a5abb. Consider uploading reports for the commit b6a5abb to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   36.97%   36.93%   -0.04%     
==========================================
  Files          77       77              
  Lines        3116     3119       +3     
  Branches      605      608       +3     
==========================================
  Hits         1152     1152              
- Misses       1964     1967       +3     
Files Coverage Δ
src/model/image-tag.ts 49.45% <28.57%> (-1.69%) ⬇️

Copy link
Member

@GabLeRoux GabLeRoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Nice one.

I see there are some jobs failing. Not sure if it's related to current changes or if they're just flaky jobs 🤷

Saving job output here in case job logs expire:

Details

Run ./
  with:
    buildName: GameCI Test Build
    projectPath: test-project
    unityVersion: [2](https://github.com/game-ci/unity-builder/actions/runs/7954027911/job/21710863347?pr=630#step:4:2)02[3](https://github.com/game-ci/unity-builder/actions/runs/7954027911/job/21710863347?pr=630#step:4:3).2.2f1
    targetPlatform: iOS
    customParameters: -profile SomeProfile -someBoolean -someValue exampleValue
    allowDirtyBuild: true
    versioning: Semantic
    androidExportType: androidPackage
    androidSymbolType: none
    runAsHostUser: false
    dockerIsolationMode: default
    containerRegistryRepository: unityci/editor
    containerRegistryImageVersion: 3
    awsStackName: game-ci
    providerStrategy: local
    kubeVolumeSize: 5Gi
    watchToEnd: true
    cacheUnityInstallationOnMac: false
    dockerWorkspacePath: /github/workspace
    skipActivation: false
  env:
    UNITY_EMAIL: ***
    UNITY_PASSWORD: ***
    UNITY_SERIAL: ***
(node:1236) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use `node --trace-warnings ...` to show where the warning was created)
/bin/sh
      57
      57

Found semantic version [4](https://github.com/game-ci/unity-builder/actions/runs/7954027911/job/21710863347?pr=630#step:4:4).0.3 for skip-activation-bug@b6a[5](https://github.com/game-ci/unity-builder/actions/runs/7954027911/job/21710863347?pr=630#step:4:5)abb
Using android versionCode 4000003
Building locally
/usr/local/bin/brew install unity-hub
==> Downloading https://public-cdn.cloud.unity3d.com/hub/prod/UnityHubSetup.dmg
Warning: No checksum defined for cask 'unity-hub', skipping verification.
==> Installing Cask unity-hub
Warning: macOS's Gatekeeper has been disabled for this Cask
==> Moving App 'Unity Hub.app' to '/Applications/Unity Hub.app'
🍺  unity-hub was successfully installed!
Error: fetch failed

src/model/image-tag.ts Show resolved Hide resolved
src/model/platform-setup/setup-mac.ts Show resolved Hide resolved
@AndrewKahr
Copy link
Member Author

Looks good to me 👍 Nice one.

I see there are some jobs failing. Not sure if it's related to current changes or if they're just flaky jobs 🤷

Saving job output here in case job logs expire:

Details

Ah, it looks like switching tests to pure il2cpp was a bit too greedy on tests as Linux can't build Windows il2cpp. I think what I'll do is still merge this PR and get the hotfix out to unbreak people's pipelines then fix the test workflow since that won't impact anyone else using the action.

@AndrewKahr AndrewKahr merged commit f4d2cce into main Feb 19, 2024
42 of 51 checks passed
@AndrewKahr AndrewKahr deleted the skip-activation-bug branch February 19, 2024 03:44
@GabLeRoux
Copy link
Member

Ah, it looks like switching tests to pure il2cpp was a bit too greedy on tests as Linux can't build Windows il2cpp. I think what I'll do is still merge this PR and get the hotfix out to unbreak people's pipelines then fix the test workflow since that won't impact anyone else using the action.

Sounds good 🚀

simon-homa pushed a commit to homagames/unity-builder that referenced this pull request Mar 7, 2024
* Fix mac env variables not getting skip activation

* Fix image tag for linux il2cpp. Force tests to use il2cpp

* Scripting backend is always il2cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants