Some text fixes #731
Merged
Some text fixes #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and keep "Link" in the item name for the spoiler log
for consistency with the other languages and the vanilla game
Kewlan
reviewed
May 21, 2024
|
|
||
| // For text boxes with an item icon, decrease max line pixel width to leave space for the icon | ||
| if (lastItemIcon != std::string::npos && (lastCaret == std::string::npos || lastItemIcon > lastCaret)) { | ||
| maxLinePixelWidth = 252; |
There was a problem hiding this comment.
Normally the text starts 56 pixels from the left of the screen, but with an icon it starts 104 pixels from the left instead, so 48 pixels further in. Any reason you reduced it by 35 pixels instead?
There was a problem hiding this comment.
I tried some different values and converged on one that fixed all the overflowing texts while changing the least amount of already correct texts.
Reducing the length more would add more newlines where they're not needed, causing more conflicts with the manually inserted ones.
Kewlan
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the maximum pixel width for text boxes that contain an item icon. Currently some messages without manual newlines look like this:
Fix Dark Link's name so it consistently uses the player name for all languages in the game's text boxes, while retaining the name "Link" for the spoiler log and custom menus. Currently the
Dark Link Soulappears asDark @ Soulin shops for non-English languages.