Skip to content

Commit

Permalink
Merge pull request #259 from schnellecom/getAllVertexCoordinates
Browse files Browse the repository at this point in the history
Add ```GetAllVertexCoordinates3DNC``` function
  • Loading branch information
MeikeWeiss authored Sep 11, 2024
2 parents f18bacd + 772bfc6 commit 4934d06
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
10 changes: 10 additions & 0 deletions PackageInfo.g
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,16 @@ Persons := [
PostalAddress := "--",
Place := "Aachen",
Institution := "Chair of Algebra and Representation Theory",
),
rec(
IsAuthor := true,
IsMaintainer := true,
FirstNames := "Lukas",
LastName := "Schnelle",
Email := "[email protected]",
PostalAddress := "--",
Place := "Aachen",
Institution := "Chair of Algebra and Representation Theory",
),
rec(
LastName := "GAP Team",
Expand Down
5 changes: 4 additions & 1 deletion gap/PolygonalComplexes/animating.gd
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,15 @@ DeclareOperation( "SetVertexCoordinates3DNC", [IsSimplicialSurface, IsList, IsRe
#! The 3D-coordinates of vertex <A>vertex</A> has to have the format <A>[x,y,z]</A>.
#! If the format of the <A>coordinates</A> is not correct, then an error is shown.
#! This can happen, if the NC version is used to store the 3D-coordinates.
#! The NC-version does not check the coordinate format saved in the print record.
#! The NC-version does not check the coordinate format saved in the print record.
#! The <A>GetAllVertexCoordinates3DNC</A> method returns all coordinates from the print record without checking them as a list.
#! @Returns a list
#! @Arguments surface, vertex, printRecord
DeclareOperation( "GetVertexCoordinates3D", [IsSimplicialSurface, IsPosInt, IsRecord] );
#! @Arguments surface, vertex, printRecord
DeclareOperation( "GetVertexCoordinates3DNC", [IsSimplicialSurface, IsPosInt, IsRecord] );
#! @Arguments surface, printRecord
DeclareOperation( "GetAllVertexCoordinates3DNC", [IsSimplicialSurface, IsRecord] );
#! @EndGroup

#! @BeginGroup DrawSurfaceToJavaScript
Expand Down
8 changes: 8 additions & 0 deletions gap/PolygonalComplexes/animating.gi
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,14 @@ InstallMethod( GetVertexCoordinates3DNC,
RedispatchOnCondition(GetVertexCoordinates3DNC, true, [IsTwistedPolygonalComplex, IsPosInt, IsRecord],
[IsSimplicialSurface], 0);

InstallMethod( GetAllVertexCoordinates3DNC,
"for a simplicial surface and a record",
[IsSimplicialSurface, IsRecord],
function(surface, printRecord)
return printRecord.vertexCoordinates3D;
end
);


InstallMethod( CalculateParametersOfInnerCircle,
"for a simplicial surface and a record",
Expand Down

0 comments on commit 4934d06

Please sign in to comment.