Merge pull request #261 from FlynnFehre/issue_255

Fixed issue #255 UmbrellaTipDescriptor
gap-packages · Aug 14, 2024 · c311df8 · c311df8
2 parents f243196 + 276e7fd
commit c311df8
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/gap/PolygonalComplexes/constructors.gi b/gap/PolygonalComplexes/constructors.gi
@@ -504,10 +504,10 @@ InstallMethod(UmbrellaTipDescriptorOfSurface,
     umbdesc:=[];
     for vertex in Vertices(surf) do
         #UmbrellaTipDescriptor for a vertex
-        umbPath:=UmbrellaPathOfVertex(surf,vertex);
-        vertEdges:=EdgesAsList(umbPath);
-        vertEdges:=List(vertEdges, x -> VerticesOfEdges(surf)[x]);
-        umbVertices:=[];
+        umbPath := UmbrellaPathOfVertex(surf,vertex);
+        vertEdges := EdgesAsList(umbPath);
+        vertEdges := List(vertEdges, x -> VerticesOfEdges(surf)[x]);
+        umbVertices := [];
         for edge in vertEdges do
             if not edge[1]=vertex then 
                 Add(umbVertices, edge[1]);
@@ -520,10 +520,10 @@ InstallMethod(UmbrellaTipDescriptorOfSurface,
         if IsClosedPath(umbPath) then
             #umbpath is a closed umbrella
             Remove(umbVertices);
-            Add(umbdesc, CycleFromList(umbVertices));
+            umbdesc[vertex] := CycleFromList(umbVertices);
         else
             #umbpath is not a closed umbrella
-            Add(umbdesc, umbVertices);            
+            umbdesc[vertex] := umbVertices;           
         fi;
     od;
     return umbdesc;