CI: test with GAP 4.13; test with mininimal set of packages loaded

[fingolfin]

No description provided.

[fingolfin]

The failure is due to a genuine issue: you use IsDigraph in gap/PolygonalComplexes/graphs.gd unconditionally.

[MeikeWeiss]

We have added Digraphs to needed packages

[fingolfin]

OK that's a bit better but the tests still report issues when loading this package using the OnlyNeeded option (which suppresses loading of packages which are merely "suggested" but not "needed" in PackageInfo.g).

First there are warnings:

Syntax warning: Unbound global variable in /tmp/gaproot/pkg/SimplicialSurfaces\
/gap/PolygonalComplexes/graphs.gi:444
        graph := NautyColoredGraph(edges, colours);
                 ^^^^^^^^^^^^^^^^^
Syntax warning: Unbound global variable in /tmp/gaproot/pkg/SimplicialSurfaces\
/gap/PolygonalComplexes/graphs.gi:446
        perminv := CanonicalLabeling(graph);
                   ^^^^^^^^^^^^^^^^^
Syntax warning: Unbound global variable in /tmp/gaproot/pkg/SimplicialSurfaces\
#I  SimplicialSurfaces: finish reading file 'read.g'
/unit_tests/test_main.g:58
    __SIMPLICIAL_Test_IncidenceNautyGraph();
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Syntax warning: Unbound global variable in /tmp/gaproot/pkg/SimplicialSurfaces\
/unit_tests/test_main.g:61
    __SIMPLICIAL_Test_EdgeNautyGraph();
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Syntax warning: Unbound global variable in /tmp/gaproot/pkg/SimplicialSurfaces\
/unit_tests/test_main.g:63
    __SIMPLICIAL_Test_FaceNautyGraph();
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Then when running the tests an actual error:

Now running tests from tst/testall.g
Error, Variable: '__SIMPLICIAL_Test_IncidenceNautyGraph' must have an assigned value in
  __SIMPLICIAL_Test_IncidenceNautyGraph(  
 ); at /tmp/gaproot/pkg/SimplicialSurfaces/unit_tests/test_main.g:58 called from 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.56%. Comparing base (dbabfb8) to head (4f40180).
Report is 53 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   78.30%   77.56%   -0.74%     
==========================================
  Files          61       61              
  Lines       16942    16706     -236     
==========================================
- Hits        13266    12958     -308     
- Misses       3676     3748      +72     

see 32 files with indirect coverage changes

[fingolfin]

Note that there is a failure here in GAP 4.11. On the surface this might be due to the digraphs & grape versions back then being less compatible, so the order in which they are loaded matters...

One simple fix would be to just require GAP >= 4.12 ?