-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lex Least Dyclet #270
Lex Least Dyclet #270
Conversation
Merge branch 'master' of github.com:gap-packages/SimplicialSurfaces
gap/utilities.g
Outdated
# this test is not conclusive as a list with rationals but | ||
# first entry an integer passes this test | ||
if not IsHomogeneousList(dyclet) or Length(dyclet) = 0 or | ||
not IsInt(dyclet[1]) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment states that the test given in the implementation is not conclusive. Is this solved by the following if clause? "if Filtered(dyclet,i-> not IsInt(i)) <> [] and Length(dylet)=0 then"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be
Filtered(dyclet,i-> not IsInt(i)) <> [] or Length(dyclet) = 0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 78.30% 78.20% -0.11%
==========================================
Files 61 61
Lines 16942 16969 +27
==========================================
+ Hits 13266 13270 +4
- Misses 3676 3699 +23
|
Utilities internal function to compare dyclets and find lex least