Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lex Least Dyclet #270

Merged
merged 10 commits into from
Sep 9, 2024
Merged

Lex Least Dyclet #270

merged 10 commits into from
Sep 9, 2024

Conversation

aniemeyer
Copy link
Collaborator

Utilities internal function to compare dyclets and find lex least

gap/utilities.g Outdated
# this test is not conclusive as a list with rationals but
# first entry an integer passes this test
if not IsHomogeneousList(dyclet) or Length(dyclet) = 0 or
not IsInt(dyclet[1]) then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states that the test given in the implementation is not conclusive. Is this solved by the following if clause? "if Filtered(dyclet,i-> not IsInt(i)) <> [] and Length(dylet)=0 then"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be
Filtered(dyclet,i-> not IsInt(i)) <> [] or Length(dyclet) = 0

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 78.20%. Comparing base (f243196) to head (8ce53b2).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
gap/utilities.g 11.53% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   78.30%   78.20%   -0.11%     
==========================================
  Files          61       61              
  Lines       16942    16969      +27     
==========================================
+ Hits        13266    13270       +4     
- Misses       3676     3699      +23     
Files with missing lines Coverage Δ
gap/utilities.g 46.51% <11.53%> (-53.49%) ⬇️

@MeikeWeiss MeikeWeiss merged commit 2713b15 into gap-packages:master Sep 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants