Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix in ConcatenationPaths #272

Merged
merged 1 commit into from
Sep 10, 2024
Merged

bug fix in ConcatenationPaths #272

merged 1 commit into from
Sep 10, 2024

Conversation

aniemeyer
Copy link
Collaborator

There is a bug in ConcatenationOfPaths whereby two paths are to be concatenated. The use of Union created a set and not an ordered list, which leads to a bug.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.20%. Comparing base (113f0df) to head (053a219).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   78.30%   78.20%   -0.11%     
==========================================
  Files          61       61              
  Lines       16942    16969      +27     
==========================================
+ Hits        13266    13270       +4     
- Misses       3676     3699      +23     
Files with missing lines Coverage Δ
gap/Paths/paths.gi 84.77% <100.00%> (ø)

... and 1 file with indirect coverage changes

@MeikeWeiss MeikeWeiss merged commit 871385f into master Sep 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants