Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added method for double n-gon #290

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Added method for double n-gon #290

merged 3 commits into from
Sep 23, 2024

Conversation

MeikeWeiss
Copy link
Collaborator

Issue #286

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.36%. Comparing base (60b6865) to head (252c13f).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
gap/Library/library.gi 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   76.39%   76.36%   -0.03%     
==========================================
  Files          63       63              
  Lines       16381    16399      +18     
==========================================
+ Hits        12514    12523       +9     
- Misses       3867     3876       +9
Files with missing lines Coverage Δ
gap/Library/library.gd 100.00% <100.00%> (ø)
gap/Library/library.gi 59.92% <93.33%> (+0.99%) ⬆️

... and 1 file with indirect coverage changes

aniemeyer
aniemeyer reviewed Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@aniemeyer aniemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice.

gap/Library/library.gd Outdated
#! <Filt Name="SimplicialDoubleGon" Arg="nrFaces" Type="operation"/>
#! <Returns><K>a simplicial surface</K></Returns>
#! <Description>
#! Return a simplicial surface consisting of two closed umbrella-path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consisting of two closed umbrella-paths

@MeikeWeiss MeikeWeiss closed this Sep 23, 2024
@MeikeWeiss MeikeWeiss reopened this Sep 23, 2024
@MeikeWeiss MeikeWeiss merged commit 8264009 into gap-packages:master Sep 23, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniemeyer aniemeyer aniemeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeikeWeiss @aniemeyer