Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GAP 4.13 #46

Closed
wants to merge 1 commit into from
Closed

Fix for GAP 4.13 #46

wants to merge 1 commit into from

Conversation

fingolfin
Copy link
Member

Unfortunately this breaks compatibility with older version.
Adjusting this to work in all versions is left as exercise.

@ThomasBreuer
Copy link
Collaborator

@fingolfin What about adding the following function

# for compatibility with both GAP 4.13 and older GAP versions
BindGlobal("InstallMethodOrTagBasedMethod", function(oper, requirements, method)
  if IsBoundGlobal("InstallTagBasedMethod") then
    # for GAP 4.13 or newer
    ValueGlobal("InstallTagBasedMethod")(oper, requirements[1], method);
  else
    # for GAP 4.12 or older
    InstallMethod(oper, requirements, method);
  fi;
end);

and calling InstallMethodOrTagBasedMethod instead of InstallMethod for NewVector and NewZeroVector (and also for NewMatrix and NewZeroMatrix)?

Then tst/testall.g runs without errors in GAP 4.12.2.
With the GAP master branch, I get a segmentation fault in tst/testinstall/bsmat.tst.

@fingolfin
Copy link
Member Author

Fine by me. It doesn't matter much as this packages is essentially dead I am afraid :-(

@ThomasBreuer ThomasBreuer mentioned this pull request Sep 9, 2024
@fingolfin fingolfin closed this Sep 16, 2024
@fingolfin fingolfin deleted the mh/NewVector branch September 16, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants