Let the user choose what function to use for the computation of Groebner bases. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced everywhere GBNPGroebnerBasis with GroebnerBasisFunction.
This is a high-level implementation and therefore certainly not as fast as GBNPGroebnerBasis. However, GBNPGroebnerBasis sometimes results in unpredictable bugs such that having an alternative seems reasonable.
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 47.61% 47.49% -0.12%
==========================================
Files 68 70 +2
Lines 23278 23401 +123
==========================================
+ Hits 11083 11115 +32
- Misses 12195 12286 +91
|
|
Thank you very much for this contribution! The QPA-team. |
|
Observer's remark: It will be nice to add some tests. As you can see at https://codecov.io/gh/gap-packages/qpa/pull/25/diff, a large fraction of new code is not exercised. Even if some testing of this code has been performed while reviewing this PR, it will not be checked by future tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #20 and replaces #21.
At the moment,
GBNPGroebnerBasisis used at many places in the source. The first commit in this pull request replaces all occurrences of this function with a variableGroebnerBasisFunctionso that QPA can work with whatever package computing Groebner bases. The user may now specify as a third optional argument forPathAlgebrathisGroebnerBasisFunction. By default nothing changes.The second and third commit of this pull request define a function
HighLevelGroebnerBasisas an alternative toGBNPGroebnerBasis. I wrote this as a temporary fix for #20.Maybe it is enough to consider only the first commit for merging in case you think that the last two commits
045eab7and1afafbbmake the source code unnecessarily bloated and intransparent.