Implement WeaklyDivisibleSemiring
for BooleanWeight
#284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the definition in the docs for
WeaklyDivisibleSemiring
,BooleanWeight
(S = bool
,+ = |
,* = &
,0 = false
,1 = true
) should be weakly divisible: there are three combinations(x, y)
such thatx + y != 0
:x = true
,y = true
: in this case, we can setz = true
so thattrue = (true | true) & true
.x = true
,y = false
: we can setz = true
so thattrue = (true | false) & true
.x = false
,y = true
: we can setz = false
so thatfalse = (false | true) & false
.In fact,
BooleanWeight
is divisible because the inverse oftrue
istrue
.This PR adds an implementation of
WeaklyDivisibleSemiring
forBooleanWeight
.