Update ERC-6538 Deployment Method and Security Considerations sections #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyghayrat
force-pushed
the
update-erc-6538
branch
from
b6e0188
to
89df2fa
Compare
garyghayrat
changed the title
mds1
reviewed
Dec 20, 2023
mds1
reviewed
Dec 22, 2023
ERCS/erc-6538.md
Outdated
| } | ||
| } | ||
|
|
||
| /// @notice Overload of {ECDSA-tryRecover} that receives the `v`, `r` and `s` signature fields |
There was a problem hiding this comment.
Similar comment to the other PR about fixing all natspec to not use OZ's custom style
There was a problem hiding this comment.
I'll update this once we merge ScopeLift/stealth-address-erc-contracts#5
garyghayrat
force-pushed
the
update-erc-6538
branch
2 times, most recently
from
0298a0c
to
bef71ad
Compare
garyghayrat
force-pushed
the
update-erc-6538
branch
from
bef71ad
to
e6f30fc
Compare
|
Submitted to the official repo here: ethereum#259 |
garyghayrat
pushed a commit
that referenced
this pull request
Mar 5, 2024
* Update erc-7007.md to add opML compatibility (#1) * Update erc-7007.md to add opML compatibility * Update erc-7007.md param name * Create IOpmlLib.sol * Update and rename ERC7007.sol to ERC7007_zkml.sol * Update IOpmlLib.sol * Update IOpmlLib.sol * Update IOpmlLib.sol * Create ERC7007_opml.sol * Update ERC7007_opml.sol * Update IOpmlLib.sol * feat: update implementation to include owner address * feat: update authorship, added Updatable extension, update metadata with `proof_type` * fix: full term before abbreviation * feat: Update ERC7007 contracts and add IERC7007Updatable interface * feat: Add rationale and security considerations * feat: `update` function to use `verify` in `require` statement * misc: capitalization * xhyu patch 1 (#2) * misc: improve abstract & motivation * fix: Spec intro & Model Publication wording * fix: Rewrite part of motivation * corrected some small typos * rewrote the last two paragraphs in Motivation --------- Co-authored-by: drCathieSo.eth <[email protected]> * fix: proposal reference and header * fix: file references * Update erc-7007.md: Fix wordings (#4) * Update erc-7007.md: Fix wordings * update license * Update description and motivation -> rationale --------- Co-authored-by: drCathieSo.eth <[email protected]> * Add workflow (#5) * Add workflow diagram * Add workflow description * Apply suggestions from code review Co-authored-by: Sam Wilson <[email protected]> * Update erc-7007.md * Fix uppercase keywords * Update erc-7007.md --------- Co-authored-by: 李婷婷 Lee Ting Ting <[email protected]> Co-authored-by: xhyumiracle <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: