v2.0.1

gasparesganga · Mar 16, 2018 · 4660a66 · 4660a66
1 parent cdebed0
commit 4660a66
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,13 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
 
+## v2.0.1 - 2018-03-16
+### Fixed
+- Changed value for overlay `justify-content` CSS property from `space-evenly` to `space-around`: Edge didn't like the former
+- Set explicit `width` and `height` for SVG, addressing bug in Chrome
+
+
+
 ## v2.0.0 - 2018-03-16
 ### Added
 - SVG images support

diff --git a/dist/loadingoverlay.js b/dist/loadingoverlay.js
@@ -1,7 +1,7 @@
 /***************************************************************************************************
 LoadingOverlay - A flexible loading overlay jQuery plugin
     Author          : Gaspare Sganga
-    Version         : 2.0.0
+    Version         : 2.0.1
     License         : MIT
     Documentation   : https://gasparesganga.com/labs/jquery-loading-overlay/
 ***************************************************************************************************/
@@ -83,7 +83,7 @@ LoadingOverlay - A flexible loading overlay jQuery plugin
             "display"           : "flex",
             "flex-wrap"         : "nowrap",
             "align-items"       : "center",
-            "justify-content"   : "space-evenly"
+            "justify-content"   : "space-around"
         },
         element : {
             "box-sizing"        : "border-box",
@@ -93,6 +93,10 @@ LoadingOverlay - A flexible loading overlay jQuery plugin
             "justify-content"   : "center",
             "align-items"       : "center"
         },
+        element_svg : {
+            "width"             : "100%",
+            "height"            : "100%"
+        },
         progress_wrapper: {
             "position"          : "absolute",
             "top"               : "0",
@@ -222,10 +226,13 @@ LoadingOverlay - A flexible loading overlay jQuery plugin
                 if (settings.image.slice(0, 4).toLowerCase() === "<svg" && settings.image.slice(-6).toLowerCase() === "</svg>") {
                     // Inline SVG
                     element.append(settings.image);
+                    element.children().css(_css.element_svg);
                     if (!settings.imageClass && settings.imageColor) element.css("fill", settings.imageColor);
                 } else if (settings.image.slice(-4).toLowerCase() === ".svg" || settings.image.slice(0, 14).toLowerCase() === "data:image/svg") {
                     // SVG file or base64-encoded SVG
-                    element.load(settings.image);
+                    element.load(settings.image, function(){
+                        element.children().css(_css.element_svg);
+                    });
                     if (!settings.imageClass && settings.imageColor) element.css("fill", settings.imageColor);
                 } else {
                     // Raster

diff --git a/dist/loadingoverlay.min.js b/dist/loadingoverlay.min.js
diff --git a/dist/loadingoverlay.min.js.map b/dist/loadingoverlay.min.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "gasparesganga-jquery-loading-overlay",
-    "version": "2.0.0",
+    "version": "2.0.1",
     "description": "A flexible loading overlay jQuery plugin",
     "homepage": "https://gasparesganga.com/labs/jquery-loading-overlay/",
     "author": "Gaspare Sganga <[email protected]> (https://gasparesganga.com)",

diff --git a/src/loadingoverlay.js b/src/loadingoverlay.js
@@ -1,7 +1,7 @@
 /***************************************************************************************************
 LoadingOverlay - A flexible loading overlay jQuery plugin
     Author          : Gaspare Sganga
-    Version         : 2.0.0
+    Version         : 2.0.1
     License         : MIT
     Documentation   : https://gasparesganga.com/labs/jquery-loading-overlay/
 ***************************************************************************************************/
@@ -83,7 +83,7 @@ LoadingOverlay - A flexible loading overlay jQuery plugin
             "display"           : "flex",
             "flex-wrap"         : "nowrap",
             "align-items"       : "center",
-            "justify-content"   : "space-evenly"
+            "justify-content"   : "space-around"
         },
         element : {
             "box-sizing"        : "border-box",
@@ -93,6 +93,10 @@ LoadingOverlay - A flexible loading overlay jQuery plugin
             "justify-content"   : "center",
             "align-items"       : "center"
         },
+        element_svg : {
+            "width"             : "100%",
+            "height"            : "100%"
+        },
         progress_wrapper: {
             "position"          : "absolute",
             "top"               : "0",
@@ -222,10 +226,13 @@ LoadingOverlay - A flexible loading overlay jQuery plugin
                 if (settings.image.slice(0, 4).toLowerCase() === "<svg" && settings.image.slice(-6).toLowerCase() === "</svg>") {
                     // Inline SVG
                     element.append(settings.image);
+                    element.children().css(_css.element_svg);
                     if (!settings.imageClass && settings.imageColor) element.css("fill", settings.imageColor);
                 } else if (settings.image.slice(-4).toLowerCase() === ".svg" || settings.image.slice(0, 14).toLowerCase() === "data:image/svg") {
                     // SVG file or base64-encoded SVG
-                    element.load(settings.image);
+                    element.load(settings.image, function(){
+                        element.children().css(_css.element_svg);
+                    });
                     if (!settings.imageClass && settings.imageColor) element.css("fill", settings.imageColor);
                 } else {
                     // Raster