allow invalid auth header for presigned urls #680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where I upload files with presigned links and my requests already contain Authentication header for another application. The app is tested against regular s3, which ignores the header and parses info from presigned link. s3proxy only parses parameters from url if the Authentication header is not present.
I suggest we change the behavior to mimick s3 better: we will will try to construct S3AuthorizationHeader from Auth header and if it fails or header is not present try to parse url parameters.