Resorce Leak compiler error/warning (detection) has some problem

fixes eclipse-jdt#2207 Don't run tests using lambda below compliance 1.8
gayanper · Sep 7, 2024 · 000c9bb · 000c9bb
1 parent 5b7c9c4
commit 000c9bb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/...mpiler/src/org/eclipse/jdt/core/tests/compiler/regression/ResourceLeakAnnotatedTests.java b/...mpiler/src/org/eclipse/jdt/core/tests/compiler/regression/ResourceLeakAnnotatedTests.java
@@ -1461,6 +1461,8 @@ static void test() {
 			false);
 }
 public void testGH2207_2() {
+	if (this.complianceLevel < ClassFileConstants.JDK1_8)
+		return;
 	Map<String, String> options = getCompilerOptions();
 	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
 	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
@@ -1504,6 +1506,8 @@ void consumerNOK(ResourceProducer producer) {
 		options);
 }
 public void testGH2207_3() {
+	if (this.complianceLevel < ClassFileConstants.JDK1_8)
+		return;
 	Map<String, String> options = getCompilerOptions();
 	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
 	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);
@@ -1543,6 +1547,8 @@ void consumer(ResourceProducer producer) {
 		options);
 }
 public void testGH2207_4() {
+	if (this.complianceLevel < ClassFileConstants.JDK1_8)
+		return;
 	Map<String, String> options = getCompilerOptions();
 	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);
 	options.put(CompilerOptions.OPTION_ReportUnclosedCloseable, CompilerOptions.ERROR);

diff --git a/....tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/ResourceLeakTests.java b/....tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/ResourceLeakTests.java
@@ -7148,6 +7148,8 @@ void test(int sw) {
 		options);
 }
 public void testGH2207_1() {
+	if (this.complianceLevel < ClassFileConstants.JDK1_8)
+		return;
 	// relevant only since 19, where ExecutorService implements AutoCloseable
 	Map options = getCompilerOptions();
 	options.put(CompilerOptions.OPTION_ReportPotentiallyUnclosedCloseable, CompilerOptions.ERROR);