Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stable branch for gz-cmake4 #165

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Use stable branch for gz-cmake4 #165

merged 3 commits into from
Aug 21, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 20, 2024

@azeey
Use stable branch for gz-cmake4
b3f23d0 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from j-rivero as a code owner August 20, 2024 21:44
@azeey azeey mentioned this pull request Aug 20, 2024
Open
@scpeters
Copy link
Contributor

I think we need to change the gz-cmake branch for every single Ionic package file and the collection file, right?

@azeey
Use stable branch in dependees
4d842af 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey
Copy link
Contributor Author

azeey commented Aug 21, 2024

I think we need to change the gz-cmake branch for every single Ionic package file and the collection file, right?

Done in 4d842af

@azeey azeey mentioned this pull request Aug 21, 2024
Merged
scpeters
scpeters reviewed Aug 21, 2024
View reviewed changes
collection-ionic.yaml Outdated Show resolved Hide resolved
@azeey
Fix explicit start
a979b04 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey merged commit 1afeb8f into master Aug 21, 2024
4 checks passed
@azeey azeey deleted the azeey/stable/gz-cmake4 branch August 21, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @scpeters