Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validating list Gazebo distributions using collections YAML #68

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Validating list Gazebo distributions using collections YAML #68

merged 3 commits into from
Sep 9, 2024

Conversation

sauk2
Copy link
Collaborator

@sauk2 sauk2 commented Aug 22, 2024

Closes #49

Summary

Previously input Gazebo distributions were validated against a hardcoded list of distribution names. Now the validation is done by fetching the collections YAML.

@sauk2 sauk2 requested a review from j-rivero August 22, 2024 11:02
@sauk2
Added comment about collections
941ed68 
Signed-off-by: Saurabh Kamat <[email protected]>
j-rivero
j-rivero reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need to refactor the function that parse the Gazebo collections from the yaml file at some point but that can wait. Good work.

@j-rivero j-rivero merged commit a3350fb into gazebo-tooling:main Sep 9, 2024
23 checks passed
@sauk2 sauk2 deleted the fix/yaml-distro-validation branch September 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse collections from YAML to get Ubuntu compatibility
2 participants
@sauk2 @j-rivero