Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows install for Dome #157

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Windows install for Dome #157

merged 4 commits into from
Mar 16, 2021

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Porting #126 to Dome. Also added ign-rendering to the list of conda packages from Dome.

@mabelzhang , do you think you could give it a look?

Test it

I recommend using meld to see the diff between citadel and dome:

meld citadel dome

Checklist

  • Signed all commits for DCO
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mabelzhang March 10, 2021 21:57
@chapulina chapulina added the documentation Improvements or additions to documentation label Mar 10, 2021
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Mar 10, 2021
@chapulina chapulina mentioned this pull request Mar 10, 2021
2 tasks
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

I removed the caveats for ign-cmake because they're not needed anymore since gazebosim/gz-cmake#154.

@chapulina chapulina added the Windows Windows support label Mar 15, 2021
Copy link
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ign-rendering Conda package worked for me:

>conda search libignition-rendering4 --channel conda-forge --info
>conda install libignition-rendering4 --channel conda-forge

colcon instructions for source install worked as well.

Do we need to update the per-library tutorial for ign-rendering?

dome/install_windows_src.md Outdated Show resolved Hide resolved
dome/install_windows_src.md Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit b95ef4b into master Mar 16, 2021
@chapulina chapulina deleted the chapulina/dome/windows branch March 16, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation 🔮 dome Ignition Dome Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants