Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for loading gltf with external textures #409

Merged
merged 5 commits into from
Aug 31, 2022

Conversation

luca-della-vedova
Copy link
Member

🎉 New feature

Summary

This PR is a followup of #393 and as discussed in #393 (comment) it adds a test to make sure loading GLTF meshes with external textures works as well.

Test it

It's a new unit test so it will be handled by CI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #409 (92be243) into gz-common5 (aec75f5) will increase coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           gz-common5     #409      +/-   ##
==============================================
+ Coverage       80.54%   80.56%   +0.02%     
==============================================
  Files              85       85              
  Lines            9956     9956              
==============================================
+ Hits             8019     8021       +2     
+ Misses           1937     1935       -2     
Impacted Files Coverage Δ
graphics/src/AssimpLoader.cc 89.01% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Aug 1, 2022
@chapulina chapulina added the bug Something isn't working label Aug 1, 2022
@chapulina chapulina changed the base branch from main to gz-common5 August 5, 2022 19:05
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use joinPaths rather than explicit slashes.

graphics/src/AssimpLoader_TEST.cc Outdated Show resolved Hide resolved
graphics/src/AssimpLoader_TEST.cc Show resolved Hide resolved
@mjcarroll
Copy link
Contributor

A small nit, but if we are including an image, can it be the gazebo logo?

Signed-off-by: Luca Della Vedova <[email protected]>
@chapulina chapulina enabled auto-merge (squash) August 26, 2022 22:08
@chapulina chapulina merged commit 629a9be into gz-common5 Aug 31, 2022
@chapulina chapulina deleted the test/gltf_external_texture branch August 31, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants