-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for loading gltf with external textures #409
Conversation
Signed-off-by: Luca Della Vedova <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-common5 #409 +/- ##
==============================================
+ Coverage 80.54% 80.56% +0.02%
==============================================
Files 85 85
Lines 9956 9956
==============================================
+ Hits 8019 8021 +2
+ Misses 1937 1935 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use joinPaths
rather than explicit slashes.
A small nit, but if we are including an image, can it be the gazebo logo? |
Signed-off-by: Luca Della Vedova <[email protected]>
09f90cd
to
bab4260
Compare
🎉 New feature
Summary
This PR is a followup of #393 and as discussed in #393 (comment) it adds a test to make sure loading GLTF meshes with external textures works as well.
Test it
It's a new unit test so it will be handled by CI.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.