Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cmd on Windows #446

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fixed cmd on Windows #446

merged 1 commit into from
Oct 5, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 15, 2024

🦟 Bug fix

Summary

The cmd file installed on Windows points to a non-existent directory:

LIBRARY_NAME = '../../../lib/gz-fuel_tools10.dll'

Whereas the dll is in bin, not lib.

This PR copies the logic from gz-sim and sdformat.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Martin Pecka <[email protected]>
@peci1 peci1 requested a review from nkoenig as a code owner September 15, 2024 00:29
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 15, 2024
@iche033 iche033 merged commit e5bfbe9 into gazebosim:gz-fuel-tools10 Oct 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants