-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ign_TEST #420
Fix ign_TEST #420
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #420 +/- ##
============================================
+ Coverage 65.45% 66.10% +0.65%
============================================
Files 29 29
Lines 3216 3216
============================================
+ Hits 2105 2126 +21
+ Misses 1111 1090 -21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
🦟 Bug fix
Related to
Summary
I merged #392 without noticing that there was a new Windows test failure. That's why the check requirements are so important 😅
Disabled the new test on Windows, and removed just the offending expectation on the
list
test.I re-enabled it on all platforms just to see how it goes, then I may disable it for macOS and/or Windows as needed.Checklist
Updated documentation (as needed)Updated migration guide (as needed)Consider updating Python bindings (if the library has them)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸