Deprecate LOCAL2 in SphericalCoordinates

[arjo129]

🦟 Bug fix

Summary

cc: @peci

With the introduction of gazebosim/gz-math#616. We will be deprecating LOCAL2 as a work around in favor or LOCAL. As part of this change, its probably a good idea to update gz-msgs as well.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[iche033]

there is one gcc deprecation warning left: https://build.osrfoundation.org/job/gz_msgs-ci-pr_any-noble-amd64/7/gcc/

[arjo129]

Yeah, I'm not exactly sure how to solve this as the warning is coming from the generated protobuf. It seems like the Proto compiler reuses the highest value in the enum. There are several options. Perhaps I could introduce a DO_NOT_USE as the highest proto enum value?

[Crola1702]

This change in gazebosim/gz-math#616 triggered a regression in gz-transport14-debbuilder:

Reference build:

• gz-transport14-debbuilder-jammy#512
• gz-transport14-debbuilder-noble#513

Log output:

/usr/lib/x86_64-linux-gnu/pkgconfig/../../../include/gz/msgs11/gz/msgs/convert/SphericalCoordinates.hh:80:54: warning: ‘gz::math::v8::SphericalCoordinates::LOCAL2’ is deprecated [-Wdeprecated-declarations]
   80 |   return math::SphericalCoordinates::CoordinateType::LOCAL2;
      |                                                      ^~~~~~
/usr/lib/x86_64-linux-gnu/pkgconfig/../../../include/gz/math8/gz/math/SphericalCoordinates.hh:82:15: note: declared here
   82 |               LOCAL2 GZ_LOCAL2_DEPRECATED = 5
      |               ^~~~~~
autopkgtest [11:18:31]: @@@@@@@@@@@@@@@@@@@@ summary
build                FAIL stderr: In file included from /usr/lib/x86_64-linux-gnu/pkgconfig/../../../include/gz/msgs11/gz/msgs/Utility.hh:27,
autopkgtest [11:18:31]: Binaries: resetting testbed apt configuration

@arjo129 can you please take a look?

[peci1]

@Crola1702 Those errors should be fixed by this PR.

[peci1]

This PR looks good, but there still remain the warnings from protobuf-generated files. I fixed that in #451.

[arjo129]

Thanks @peci1! Will use that PR.