Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3 ➡️ 6 part1 #1602

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Merge 3 ➡️ 6 part1 #1602

merged 4 commits into from
Jul 20, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port ign-gazebo3 as of abe0ff6 to ign-gazebo6. There were a fair number of conflicts with this and other PRs, so I started with #1546.

  • I applied IGN_UTILS_TEST_DISABLED_ON_MAC to some tests moved from Server_TEST.cc to multiple_servers.cc
  • Some tests on ign-gazebo6 already had IGN_UTILS_TEST_DISABLED_ON_WIN32 and Disable MacOS flakies Citadel #1545 added IGN_UTILS_TEST_DISABLED_ON_MAC, so I merged them into IGN_UTILS_TEST_ENABLED_ONLY_ON_LINUX

Branch comparison: ign-gazebo6...abe0ff6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Blast545 and others added 2 commits June 23, 2022 12:19
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
@scpeters scpeters requested a review from chapulina as a code owner July 19, 2022 18:56
@scpeters scpeters mentioned this pull request Jul 19, 2022
8 tasks
@scpeters scpeters added the 🏯 fortress Ignition Fortress label Jul 20, 2022
@scpeters scpeters merged commit 8c66ef3 into ign-gazebo6 Jul 20, 2022
@scpeters scpeters deleted the scpeters/merge36 branch July 20, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants