Utilizes return value of AddBvhAnimation func #1632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs if adding bvh animation fails during actor creation Signed-off-by: Onur Berk Tore <[email protected]>
8 tasks
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1632 +/- ##
==========================================
Coverage ? 63.55%
==========================================
Files ? 331
Lines ? 25995
Branches ? 0
==========================================
Hits ? 16521
Misses ? 9474
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
9 tasks
ahcorde
requested changes
Aug 15, 2022
| if(!meshSkel->AddBvhAnimation(animFilename, animScale)) | ||
| { | ||
| gzerr << "Bvh animation in file " << animFilename << " failed to load" | ||
| << " during actor creation" << std::endl; |
8 tasks
|
Thanks for the PR. I've updated this and targeted to version 6 in #1750. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Related to gazebosim/gz-common#393
Summary
During actor creation adding bvh animation might fail. The current approach does not check whether bvh animation fails or not. This patch, checks whether adding bvh animation is succesfull and logs if fails.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.