Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces new mesh formats to the drag&drop err #1653

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Introduces new mesh formats to the drag&drop err #1653

merged 1 commit into from
Aug 17, 2022

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Aug 17, 2022 •
edited
Loading

🦟 Bug fix

Fixes gazebosim/gz-common#393

Summary

GUI error now includes the new mesh formats.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@onurtore onurtore mentioned this pull request Aug 17, 2022
Open
8 tasks
chapulina
chapulina approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This could target gz-sim7 if you want.

@onurtore
Copy link
Contributor Author

onurtore commented Aug 17, 2022 •
edited
Loading

@ahcorde,
Little help over here as well? For changing the target branch to gz-sim7?

Update:Oh, okay, I see the answer you shared in the other PR. I will do it. Thanks.

@ahcorde ahcorde changed the base branch from main to gz-sim7 August 17, 2022 17:33
@chapulina chapulina merged commit 942da23 into gazebosim:gz-sim7 Aug 17, 2022
@chapulina chapulina added documentation Improvements or additions to documentation 🌱 garden Ignition Garden labels Aug 17, 2022
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@ahcorde ahcorde ahcorde approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation 🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onurtore @ahcorde @chapulina