Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TriggeredPublisher test #2354

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 3, 2024

🦟 Bug fix

Summary

Fixes TriggeredPublisherTest.InputMessagesTriggerServices test which has been failing since gazebosim/gz-transport#470. The issue is that service requests from the previous test, TriggeredPublisherTest.InvalidServiceName, are received in this test and cause a mismatch on the expected number of received requests. The (hopefully) temporary solution is to sleep a small amount of time right after advertising the service so that the extraneous service requests are received and discarded before we start the main body of the test.

Also see gazebosim/gz-transport#491

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mjcarroll as a code owner April 3, 2024 03:43
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 3, 2024
@azeey
Copy link
Contributor Author

azeey commented Apr 4, 2024

@osrf-jenkins run tests please

@azeey
Copy link
Contributor Author

azeey commented Apr 4, 2024

@j-rivero The Ubuntu build keeps on using prerelease even though I've reverted gz-sim to use the stable repo in gazebo-tooling/gzdev#85. Shouldn't gzdev delete /etc/apt/sources.list.d/_gzdev_*.list and create new ones?

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey
Copy link
Contributor Author

azeey commented Apr 8, 2024

I've made another prerelease of gz-transport13 to workaround the caching issue.

@azeey
Copy link
Contributor Author

azeey commented Apr 9, 2024

The TriggeredPublisher test is now passing. The other failures on Github Action and windows seem unrelated.

@azeey azeey requested a review from iche033 April 9, 2024 15:57
@azeey azeey merged commit 6505cf2 into gazebosim:gz-sim8 Apr 9, 2024
6 of 8 checks passed
@azeey azeey deleted the fix_triggered_publisher branch April 9, 2024 18:53
@Blast545
Copy link
Contributor

Blast545 commented Apr 26, 2024

🧑‍🌾 @azeey This one made it back into CI, see:

https://build.osrfoundation.org/job/gz_sim-ci-main-jammy-amd64/65/, https://build.osrfoundation.org/job/gz_sim-ci-main-jammy-amd64/65/testReport/junit/(root)/TriggeredPublisherTest/InputMessagesTriggerServices/

Took some time to check the PRs on gz-transport and gz-sim merged in the last week, but I don't see any reason for it to appear again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants