Test refactoring part 3 #464
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-transport12 #464 +/- ##
==================================================
- Coverage 87.23% 85.64% -1.60%
==================================================
Files 60 60
Lines 5211 5211
==================================================
- Hits 4546 4463 -83
- Misses 665 748 +83 ☔ View full report in Codecov by Sentry. |
mjcarroll
changed the base branch from
gz-transport12
to
mjcarroll/test_cleanup_part2
mjcarroll
force-pushed
the
mjcarroll/test_cleanup_part3
branch
from
b10196d
to
70ee1a0
Compare
|
@caguero to take a look. |
|
@osrf-jenkins run tests please |
test/test_utils.hh
Outdated
|
|
||
| /// \brief Get the randomly generated partition for this test | ||
| /// \return string value of the partition | ||
| protected: [[nodiscard]] std::string Partition() const { |
There was a problem hiding this comment.
Nit: Opening bracket in the next line.
test/test_utils.hh
Outdated
| } | ||
|
|
||
| /// \brief Clean up the test fixture | ||
| protected: void TearDown() override { |
There was a problem hiding this comment.
Nit: Opening bracket in the next line.
| std::make_unique<gz::utils::Subprocess>(_commandLine, environment); | ||
| } | ||
|
|
||
| private: std::string prevPartition; |
There was a problem hiding this comment.
Nit: Missing doxygen doc for these members.
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/test_cleanup_part3
branch
from
5efc81c
to
d4966cc
Compare
|
@caguero I'm going to just retarget this to main. It was targeted to |
Signed-off-by: Michael Carroll <[email protected]>
Continuation of #463